Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace problematic Edge constructor with a simpler one #627

Merged
merged 9 commits into from
May 25, 2022
Merged

Conversation

hannobraun
Copy link
Owner

The constructor was problematic, because it projected the edge vertices into the curve to create the local form of the vertices, without checking whether those points lie on the curve. I also had some other concerns regarding floating point accuracy issues in the computation of these surface coordinates, but I'm not sure whether those concerns where well-founded.

In any case, the new constructors accepts the canonical and the local forms of the vertices. It doesn't verify them directly, but geometric validation will later ensure that they match.

@hannobraun
Copy link
Owner Author

A change in this pull request triggers a geometric validation issue in the star model, hence the CI failure. I've been working on improving the error reporting infrastructure, to help track this down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant