Moving the model should work without a focus point #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @jeevcat! I'll take a look tomorrow. |
hannobraun
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Thank you @jeevcat, this is great!
I've left one comment, but that's a minor thing, and I'm happy to merge this PR anyway.
Comment on lines
+31
to
+34
| [dependencies.fj-operations] | ||
| version = "0.7.0" | ||
| path = "../fj-operations" | ||
|
|
There was a problem hiding this comment.
I think it's a bit unfortunate to add the dependency on fj-operations and (indirectly) fj-kernel. It would probably be better to move ProcessedShape to fj-interop instead.
There was a problem hiding this comment.
Yeah I didn't really like adding the dependency either. Let me give your suggestion a go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #678