Release operator: Wait for crate version to appear upstream #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
previously approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Thank you @hendrikmaus, this looks great!
Notes:
- Left a nitpick comment; not important.
- I think your PR references the wrong issue. This addresses Release automation can fail, because just-published crate is not found #788, not
Release | Crates.ioin CD pipeline doesn't handlecargo publisherrors #538. - I'm leaving this PR open until
Release | Crates.ioin CD pipeline doesn't handlecargo publisherrors #538 has been fixed, as per my comment in #788.
|
I guess you are right, sry for the confusion. I'll fix the reference and open another PR for the more pressing issue. |
Thanks! |
hendrikmaus
force-pushed
the
#538_wait-for-crate-versions-to-appear
branch
from
cde61bb
to
67c6d78
Compare
|
Thank you again, @hendrikmaus! I'll take another look on Monday. |
hannobraun
previously approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Looks good to me. Thank you @hendrikmaus!\
If #834 fixes #538, I will merge this right after, before I re-trigger the automation again.
This is done so that the submit function can easily acquire the version it has to wait for to appear in the crates.io registry after submitting it. Like that, we will only advance to the next crate, when the current one was fully populated upstream
The operator will wait for 10 minutes per crate.
hannobraun
force-pushed
the
#538_wait-for-crate-versions-to-appear
branch
from
67c6d78
to
ea759e0
Compare
|
#538 is fixed. My fix introduced a merge conflict though. Rebased. Will merge, as well as CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change-set introduces a simple wait loop, with a timeout of 10 minutes, after the submission of each crate. Hence the operator will only move to the next crate in the list of crates to publish once the current one has fully populated.
Fixes #788