Add ignored failing unit test for triangulation bug #430 #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
reviewed
Jul 18, 2022
There was a problem hiding this comment.
Thank you, @willhansen! I like it, especially the ASCII art drawing 😄
I left one comment with a question.
| fn triangulate(face: Face) -> anyhow::Result<Mesh<Point<3>>> { | ||
| let tolerance = Tolerance::from_scalar(Scalar::ONE)?; | ||
| let tolerance = Tolerance::from_scalar(Scalar::ONE * 0.0001)?; |
There was a problem hiding this comment.
Was this change necessary in some way? The tests only use polygons as input for the triangulation, no circles or anything else that would need to be approximated. The tolerance (which is used to determine the precision of the approximation) should make no difference.
There was a problem hiding this comment.
Not required. I didn't realize it was only used for curves.
There was a problem hiding this comment.
Thanks for clarifying! Probably worth adding a comment, next time I'm touching that piece of code.
#430 Fix gitignore not ignoring .idea/ directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#430
Also fix gitignore not ignoring .idea/ directory