Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading model libraries doesn't work on platforms other than Linux #11

Closed
hannobraun opened this issue Nov 22, 2021 · 5 comments
Closed

Loading model libraries doesn't work on platforms other than Linux #11

hannobraun opened this issue Nov 22, 2021 · 5 comments
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

Right now, the host application expects the dynamic library to end with .so, which is correct on Linux. It should either fall back to other file endings to support more platforms, or there might be a way to override the file name outright, and set it to something like .model.
@hannobraun hannobraun added the type: feature New features and improvements to existing features label Nov 22, 2021
@hannobraun
Copy link
Owner Author

In case anyone wants to take a look, the library is loaded in model.rs. If it's practical to override the whole file name, this also needs to happen in model.rs

@hannobraun hannobraun added the good first issue Good for newcomers label Nov 22, 2021
@hannobraun
Copy link
Owner Author

I initially thought of this as an enhancement (as in, it works fine, it should work fine in more places), but I think it makes more sense to classify it as a bug.

@hannobraun hannobraun added type: bug Something isn't working and removed type: feature New features and improvements to existing features labels Nov 23, 2021
@hannobraun hannobraun changed the title Make sure model libraries are handled correctly on all platforms Loading model libraries doesn't work on platforms other than Linux Nov 23, 2021
@Bandsberg
Copy link
Contributor

For OSX: dynamic library: .dylib (e.g. libspacer.dylib) results in "Error: Error request adapter". Error defined in renderer.rs
Will continue to investigate next time I have time

@hannobraun
Copy link
Owner Author

@Bandsberg I think what you're seeing is most likely #10, not this issue.

@Bandsberg Bandsberg mentioned this issue Dec 17, 2021
Merged
@hannobraun
Copy link
Owner Author

Fixed by @Bandsberg in #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannobraun @Bandsberg