Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation failures should not prevent geometry from being built #1627

Closed
hannobraun opened this issue Feb 27, 2023 · 1 comment
Closed

Validation failures should not prevent geometry from being built #1627

hannobraun opened this issue Feb 27, 2023 · 1 comment
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

There are various requirements that shapes must uphold, in order to be considered valid. Most of these requirements are checked as objects are being constructed (only most; there are open issues for missing validation checks). Always checking these makes sense, to prevent bugs or user error.

Currently, a validation failure leads to a runtime panic. Aside from not being user-friendly, this is fundamentally the wrong behavior. The error messages from validation failures are often not bad, as far as error messages go, but they are still text-based. This makes understanding them very difficult.

What would make them easier to understand, is to see the invalid shape graphically, which is exactly what validation failures currently prevent. Eventually, it would be great to show the validation error graphically, pointing exactly where something is wrong. For now, it'll be enough to display the invalid geometry and show the validation error as a status message.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: ui topic: core Issues relating to core geometry, operations, algorithms labels Feb 27, 2023
@hannobraun
Copy link
Owner Author

This issue is no longer applicable. The affected code has been removed. See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant