Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sweeping in arbitrary directions #192

Closed
hannobraun opened this issue Feb 16, 2022 · 0 comments · Fixed by #505
Closed

Support sweeping in arbitrary directions #192

hannobraun opened this issue Feb 16, 2022 · 0 comments · Fixed by #505
Labels
good first issue Good for newcomers topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

At this point, sweeping is only possible along the z-axis. However, most of the code in the kernel that supports sweeping already works with arbitrary vectors. Sweeping in arbitrary directions might be possible to support without much work.

This would involve accepting a vector instead of a scalar in fj::Sweep, then passing that vector directly to the respective places in the kernel, instead of constructing such a vector from fj::Sweep's length field. Some changes might be necessary to internal kernel APIs. The places that need modifications should be fairly obvious after changing fj::Sweep, by following the trail of compiler errors.

This would need to be tested thoroughly, by adding new models that test different situations (sweep along positive z, sweep along negative z, sweep along a slanted vector, sweep sketches that were rotated with fj::Transform, etc.).

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as at least the first steps of this work, as outlined above, should be fairly straight-forward and might serve as a good introduction to the fj library and the kernel. If this exposes any non-trivial problems, we can open follow-up issues for those.

@hannobraun hannobraun added type: feature New features and improvements to existing features good first issue Good for newcomers topic: model topic: core Issues relating to core geometry, operations, algorithms labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant