Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build models in repository as part of CI build #51

Closed
hannobraun opened this issue Jan 20, 2022 · 1 comment
Closed

Build models in repository as part of CI build #51

hannobraun opened this issue Jan 20, 2022 · 1 comment
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

hannobraun commented Jan 20, 2022

The CI build doesn't currently build the models in the models/ directory, which means that errors can creep in there unnoticed.

Maybe it could be as simple as creating a Cargo workspace, and adding the models to it. If not, adding a shell script (or ideally something more portable) that goes through everything in models/ and runs cargo build would work.

Labeling as https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, since this is purely a Cargo thing that doesn't require any knowledge of Fornjot.

@hannobraun hannobraun added good first issue Good for newcomers topic: model type: development Work to ease development or maintenance, without direct effect on features or bugs topic: build Anything relating to the build system. labels Jan 20, 2022
@hannobraun
Copy link
Owner Author

If adding a build script is necessary to address this issue, my musings about that topic in #64 are relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Development

No branches or pull requests

1 participant