Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more details in variable_hover #37

Closed
michaelkonecny opened this issue Sep 1, 2018 · 3 comments
Closed

more details in variable_hover #37

michaelkonecny opened this issue Sep 1, 2018 · 3 comments

Comments

@michaelkonecny
Copy link
Contributor

Just having "go to definition" thanks to fortls is great!

However, if variable_hover was improved, that would be even better!

In this example:

subroutine test()
    implicit none    

    real(8), dimension(3, 3) :: A
    real(8), dimension(3, 3) :: B ! this is the matrix i'm going to transpose

    A = transpose(B)

end subroutine

when I hover over B, could I get:

  • the other keywords in the declaration (here: dimension, but could also be intent, parameter, save, ...)
  • the comment on that line

like this:
real(8), dimension(3, 3) ! this is the matrix i'm going to transpose?

@hansec
Copy link
Owner

hansec commented Sep 3, 2018

The hover should actually show all the keywords already. However, the dimension keyword was not fully supported for explicit sizing, which was tripping up this particular case. I have a fix for this that I will merge in shortly.

I could also add trailing comments to the variable hover information without too much effort. I will work on that as well.

@hansec hansec closed this as completed in 467436b Sep 3, 2018
@hansec
Copy link
Owner

hansec commented Sep 3, 2018

I just pushed a change to master that should fix this issue. I will probably wait a little bit to see if there are any other issues you find/suggestions you have before I do another release though. I will also work on adding the trailing comments as you suggested as this is a common documentation pattern.

@michaelkonecny
Copy link
Contributor Author

Terrific.

I have also run into a piece of code that makes VS with my extension crash completely, but I haven't found out whether it's a problem on the server side or Microsoft's Client implementation yet.
It'll be a while (probably till the end of the week) until I have time to debug that, but I will keep you posted in case it's an error on the server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants