Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: document wrong use case #2

Closed
hanseo0507 opened this issue Mar 29, 2023 · 0 comments · Fixed by #4
Closed

Error: document wrong use case #2

hanseo0507 opened this issue Mar 29, 2023 · 0 comments · Fixed by #4
Assignees
@hanseo0507
Labels
bug Something isn't working

Comments

@hanseo0507
Copy link
Owner

The document describes the following use cases

toast.success("Hello, world!");

But it's actually working like this right now

toast.success({type: "Hello, World!"});
@hanseo0507 hanseo0507 added the bug Something isn't working label Mar 29, 2023
@hanseo0507 hanseo0507 self-assigned this Mar 29, 2023
@hanseo0507 hanseo0507 linked a pull request Mar 29, 2023 that will close this issue
fix(core): modify TypeToastHandler argument type #4
Merged
@hanseo0507 hanseo0507 mentioned this issue Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanseo0507 hanseo0507

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): modify TypeToastHandler argument type hanseo0507/react-toast
1 participant
@hanseo0507