Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align errors with java? #308

Open
twuebi opened this issue Aug 28, 2024 · 0 comments
Open

Align errors with java? #308

twuebi opened this issue Aug 28, 2024 · 0 comments

Comments

@twuebi
Copy link
Contributor

twuebi commented Aug 28, 2024

apache/iceberg#10908 added a compatibilty test suite to iceberg-java. A large number of tests is failing since error messages are string matched, we should decide if we want to align our error messages to the java implementation to make the most out of the compatibility test suite.

Possible alternatives:

  1. port test suite to rust (probably blocked on missing functionality in iceberg-rust)
  2. contribute a PR to iceberg java which makes the checking of error messages configurable
  3. apply a patch to iceberg java before each test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant