Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Greedy Search #62

Open
david-wei-01001 opened this issue May 21, 2024 · 0 comments
Open

Bug in Greedy Search #62

david-wei-01001 opened this issue May 21, 2024 · 0 comments

Comments

@david-wei-01001
Copy link

in lade/decoding/py line1175 the original code:

else:
                all_old_tokens.append(hits[max_hit])

should be changed to

else:
                all_old_tokens.append(hits[hit_idx])

Otherwise it is just appending the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant