Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 #226

Open
jasonsyoung opened this issue Jan 7, 2025 · 3 comments
Open

React 19 #226

jasonsyoung opened this issue Jan 7, 2025 · 3 comments

Comments

@jasonsyoung
Copy link

I couldn't find any issue referencing this, but it seems this library has a hardcoded max version of react 18. Any plans to support React 19?

@narnigrin
Copy link

For what it's worth, running the codemod recommended on https://react.dev/blog/2024/04/25/react-19-upgrade-guide shows only one change in example/index.jsx (changing render() to createRoot().render() ), so the actual component (lib/datetime-picker.jsx) seems to play fine with React 19.

@jasonsyoung
Copy link
Author

looks like there is some stuff around enzyme unit tests that will need updating. the example/index.js change is only related to examples. I will try to spend some time making a PR to update this library.

@mbohovic
Copy link

mbohovic commented Feb 3, 2025

When do you expect to update this package for React 19? Thank you for the information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants