Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some HAPI unit tests fail in PyHC Environment #75

Open
sapols opened this issue Jan 28, 2025 · 2 comments
Open

Some HAPI unit tests fail in PyHC Environment #75

sapols opened this issue Jan 28, 2025 · 2 comments

Comments

@sapols
Copy link

sapols commented Jan 28, 2025

Greetings HAPI team,

I'm opening this issue in response to a conversation we had at the last PyHC core developer tag-up.

The PyHC environment is now deployed in Binder: https://binder.opensci.2i2c.cloud/v2/gh/heliophysicsPy/science-platforms-coordination/pyhc

Included in there is a notebook unit-tests.ipynb which runs core package unit tests.

Currently, 95.65% of HAPI's tests pass when I run that notebook. Will you please look at what fails and help me bring that up to 100%?

You can click the link above to launch the environment and run the unit tests yourself. But if the link hasn't been clicked in a while it can take upwards of ten minutes to spin up. This is unfortunate but normal. For convenience I ran the notebook and uploaded it here so you can view the output without waiting.

Please take a look, see what's failing, and let me know 1) if I should update the environment somehow to get 100% of HAPI's tests passing or 2) if you can fix them in a new release.

Thank you!
Shawn

@sapols
Copy link
Author

sapols commented Jan 30, 2025

It looks like only one test is failing, actually:

FAILED hapiclient/test/test_hapitime_reformat.py::test_hapitime_reformat - isodate.isoerror.ISO8601Error: Unrecognised ISO 8601 time format: '00:00:00.Z'

Does that test pass when you all run these unit tests?

@jbfaden
Copy link
Contributor

jbfaden commented Jan 30, 2025

Hi Shawn, I asked Bob about this yesterday and I think he's looking into the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants