-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IG not installed when using POST /ImplementationGuide/$install #727
Comments
I'm unable to reproduce. I made a slight adjustment to the generation script. It is as follows: #!/bin/bash
# URL of the file to download
file_url="https://build.fhir.org/ig/jembi/ethiopia-hiv/package.tgz"
# File name after downloading
file_name="downloaded_file"
# Download the file using curl
curl -o "$file_name" "$file_url"
# Base64 encode the file content saving it to a temp file
base64 --input="$file_name" > base64_content.txt
# Generate JSON data using jq with input from the file
json_data=$(jq -n --rawfile base64_content base64_content.txt \
'{ "resourceType": "Parameters", "parameter": [ { "name": "npmContent", "valueBase64Binary": $base64_content }]}')
echo "$json_data" > parameters.json
after that, then I can inspect the structuredefinitions without any problem on /fhir/StructureDefinition. @rmrlangford please try the steps above. |
Thanks @jkiddo , the script and process as laid out above works as expected (previous process did also when only using the $install operation). If there is an IG already installed where after executing the curl request above, what is the expected behaviour on HAPI? |
That both IGs are installed |
All saved here for future runs: https://github.com/jkiddo/ig-install-parameters-generator |
Thanks @jkiddo . The reason why I ask is that if I install more than 1 IG, it only shows one IG when querying StructureDefinition and zero IG's when querying ImplementationGuide. I did two tests:
Both tests give me the same findings. And thanks for creating the repo for the new scripts! |
I can't reproduce. I tried issuing an |
Thanks @jkiddo , will test in a few hours and get back to you. |
@rmrlangford did this work? |
Hi @joofio , apologies for the late follow-up, I admit that I totally forgot about this due to other distractions. I was in the process of testing this but getting some weird issues and not sure why. Please see below. Note: this first one is encountered when using the $install operation or when using a the implementation guides config in hapi.fhir.implementationguides When using the $install operation, it doesnt seem to work and likely related to the above issue. I am starting to wonder if this is perhaps an issue local to my machine but I have deleted existing HAPI images, started the process from the beginning again yet when calling StructureDefinition to ensure that my IG is installed, I get nothing back. Commented out existing IGs to be sure that if the $install operation is used that the IG is installed when calling StructureDefinition. |
@rmrlangford I looked at your sample IG. Your Extensions (StructureDefs) has the status https://github.com/jembi/Starter-FHIR-IG/blob/33fe1b767fd1d42301c1fe290e09bbdd543466d1/input/fsh/extension.fsh#L10 |
Thanks @jkiddo , that was helpful! So the new script for the $install operation works perfectly and have verified its installation by calling StructureDefinition. Possibly something unrelated and dont want to postpone the closure of this ticket intentionally but when installing two IG's it seems to always only return the StructureDefinitions for the very last IG installed. |
Have you trawled through all pages in the response from the server? |
Ahh right, yes...I know what the issue is...will confirm in a second. |
So the issue with the IG was that it's artifacts also had a status of draft so changed to active. Still, after doing that, only one IG's StructureDefinition is shown and this time, for the first IG. I think it will be best for me to do a screen recoding and narrative and then share that? So not sure if you prefer to resolve this issue given that the $install operation is working and then based on the findings from my screen recoding, we can open a new issue (if applicable)? No errors on server. |
@rmrlangford can I ask you to be more specific. I only identified that you were referring to you sample IG because it was stated in the logs. Which IG's are you exactly referring to? |
Steps:
Actual Behaviour: When executing GET /StructureDefinition, I still see the previously installed IG from steps 1 - 2.
Expected Behaviour: When executing GET /StructureDefinition, I should see the newly installed IG from step 5.
The text was updated successfully, but these errors were encountered: