Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types of object are incorrect #2978

Open
felixmosh opened this issue Aug 23, 2023 · 0 comments · May be fixed by #2979
Open

Types of object are incorrect #2978

felixmosh opened this issue Aug 23, 2023 · 0 comments · May be fixed by #2979
Labels
support Questions, discussions, and general support

Comments

@felixmosh
Copy link
Contributor

Support plan

  • is this issue currently blocking your project? (yes):
  • is this issue affecting a production system? (no):

Context

  • node version: 18
  • module version with issue: 17.9.2
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): standalone
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

const portSchema = Joi.number().integer().greater(2999).positive().required();
const hostSchema = Joi.alternatives([Joi.string().ip(), Joi.string().domain().allow('localhost')]).required();

const envSchema = Joi.object({
  NODE_ENV: Joi.string().valid('production', 'development', 'test').required(),
  PORT: portSchema.default(3000).optional(),
  SERVICE_HOST: hostSchema,
  REDIS_PORT: portSchema,
  REDIS_HOST: hostSchema,
});

What was the result you got?

envSchema gets a type of Joi.ObjectSchema<any> instead of specific object,
image

What result did you expect?

It should contain reflect the object type...

Maybe we can use the types from https://github.com/maghis/types-joi/blob/master/index.d.ts which do work

I've managed to change types to reflect object's keys by modifying this

object<TSchema = any, isStrict = false, T = TSchema>(schema?: SchemaMap<T, isStrict>): ObjectSchema<TSchema>;

into

object<TSchema = any, isStrict = false>(schema?: SchemaMap<TSchema, isStrict>): ObjectSchema<TSchema>;

image

But it sets unknown to each key.

@felixmosh felixmosh added the support Questions, discussions, and general support label Aug 23, 2023
@felixmosh felixmosh linked a pull request Aug 24, 2023 that will close this issue
@felixmosh felixmosh changed the title Types of object are incorrect Types of object are incorrect Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Questions, discussions, and general support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant