Date.iso() does not interpret ISO-8601 dates correctly

[koresar]

var joi = require('joi');
var schema = joi.date().iso();
joi.validate('3333333', schema, function(err, value) {
  console.error(err);
  console.log(value);
});

Run the above with nodejs. It prints: Thu Jan 01 1970 10:55:33 GMT+1000 (AEST)
Whereas the date should be 3333-11-29. See ISO standard Ordinal Dates section.

Additionally, "3333-333" should be parsed to 3333-11-29 too. But we get an error: message: '"value" must be a valid ISO 8601 date'.

A side note.
moment.js does a better job parsing "3333-333" correctly. But it fails to parse "3333333".

[koresar]

This is not a huge problem until someone tries to validate a following string: "2015".
It is not ISO format, but being accepted by Joi, converts to Thu Jan 01 1970 00:00:02 date.

[Marsup]

Joi converts anything that looks like an integer into one, assuming it's a unix timestamp, it's a design choice, if you don't agree with it you can always set the strict mode.
As for the 2nd case, JavaScript supports a limited version of ISO8601 and we rely on that, if you see a better approach that can take the best of both worlds (considering we already have moment), patch welcome.

EDIT: strict mode will actually fail every time with a string, so you either agree with the choice, or use Joi.string().isoDate() and parse it yourself.

[koresar]

Thanks for the fix. Is isoDate() published to npm?

[koresar]

Yep, it's published and working as expected. The isoDate() accepts the 3333-333 string.

[Marsup]

It always has been, I just remembered it was not documented.

[Marsup]

If you ever find a way to make it work whatever the format, feel free to submit a patch or the steps to follow.

[koresar]

Yep, I'm thinking of it.

[aaronjameslang]

If this behaviour is by design, can this issue be closed?

[Marsup]

I don't think we'll ever come to a fix for this one.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.