Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stupid typescript #938

Closed
hueniverse opened this issue Sep 1, 2019 · 3 comments
Closed

Stupid typescript #938

hueniverse opened this issue Sep 1, 2019 · 3 comments
Assignees
@hueniverse
Labels
bug Bug or defect dependency Update module dependency
Milestone
20.2.2

Comments

@hueniverse
Copy link
Contributor

Changing error codes without major because I guess they don't think anyone should be using error codes programmatically...

New error code 2769 added.

For people who care about strict typing, this is fucking absurd...

Disclaimer: I'm at the end of an 11 hours flight and this is not the kind of shit I need to solve 20 minutes before landing so I can fix a cascade of bugs in other modules.
@hueniverse hueniverse added bug Bug or defect dependency Update module dependency labels Sep 1, 2019
@hueniverse hueniverse added this to the 20.2.2 milestone Sep 1, 2019
@hueniverse hueniverse self-assigned this Sep 1, 2019
@hueniverse hueniverse mentioned this issue Sep 1, 2019
Closed
@kanongil
Copy link
Contributor

kanongil commented Sep 2, 2019

You should probably fix the typescript dependency to a major + minor version since typescript does not follow semver. See microsoft/TypeScript#14116.

@hueniverse
Copy link
Contributor Author

Good idea.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
bug Bug or defect dependency Update module dependency
Projects
None yet
Milestone
20.2.2
Development

No branches or pull requests
2 participants
@hueniverse @kanongil