Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track leaking timers, sockets, open files, child processes, etc #988

Open
kanongil opened this issue Aug 20, 2020 · 2 comments
Open

Track leaking timers, sockets, open files, child processes, etc #988

kanongil opened this issue Aug 20, 2020 · 2 comments
Labels
feature New functionality or improvement

Comments

@kanongil
Copy link
Contributor

kanongil commented Aug 20, 2020

What problem are you trying to solve?

Track any leaking open file descriptors. Currently this is done in inert through a platform-specific hack.

Do you have a new or modified API suggestion to solve the problem?

Add a new option / flag, that will make the tests fail on any such leak. Both at an individual test level, and at a global level, similar to the already integrated leak detection.

Besides making the inert tests simpler, and platform agnostic, this feature can help expose issues in existing code and tests.

See wtfnode for a way to do this.

@kanongil kanongil added the feature New functionality or improvement label Aug 20, 2020
@devinivy
Copy link
Member

devinivy commented Sep 2, 2020

I would personally support taking a PR for this feature request as described 👍

@kanongil
Copy link
Contributor Author

kanongil commented Sep 2, 2020

I suspect an implementation would consist of 2 parts. A new module that enables the tracking, and a subsequent integration into lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

2 participants