This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Assignment6 #152
Merged
Assignment6 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zoe-1 Yeah, I would beef up the tests. |
| './private': {}, | ||
| './home': {}, | ||
| './version': [{ | ||
| 'select': ['web', 'web-tls'] |
There was a problem hiding this comment.
why register the plugins also on web when all routes are redirected to web-tls?
There was a problem hiding this comment.
@AdriVanHoudt, I think you are right 👍 , since everything gets caught and redirected to https before being routed, it may be not necessary to register web.
There was a problem hiding this comment.
seems unnecessary at least
There was a problem hiding this comment.
Agree, will be addressed in the next commit.
|
@AdriVanHoudt Good to have you back making comments again. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting assignment6 #144