Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all replacement strings in both current pull and overall count text #57

Open
Aeon234 opened this issue Jul 30, 2023 · 5 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Aeon234
Copy link
Contributor

Aeon234 commented Jul 30, 2023

With the new update it was documented that :percentafterpull: should display the percent after the pull is finished, but when using the custom text format and placing :percentafterpull: string, instead of the actual percentage all you get is just the string being displayed as text. Doesn't matter if it's in demo mode or in an actual dungeon.

For reference on the picture below the custom text is: (+:count: / :percent:) (:percentafterpull:)

image

@happenslol
Copy link
Owner

Thanks for the report, I'll have a look at this.

@happenslol
Copy link
Owner

I just checked ingame, and it seems to work fine for me. Just a hunch... Could it be that you inserted the :percentafterpull: tag in the "Current pull text format" box, and not in the "Forces text format" box? We don't replace that tag in there, but maybe we should. There's not really any reason to not make all tags available in both fields, the only difference is that the second one is only display while you have an active pull.

@Aeon234
Copy link
Contributor Author

Aeon234 commented Jul 30, 2023

Yup, exactly. I placed it in the Current pull text format. I've just trained my eyes to go to that specific string when it comes to figuring out whether the current pull is sufficient.

image

@happenslol
Copy link
Owner

Ah right, that's the problem then. The string will only be replaced in the forces text, not the current pull text. I can add the other replacements to the current pull text as well and include that in the next release, but until then you'll have to use the forces text for that field.

@happenslol
Copy link
Owner

Hey, sorry for the long radio silence here. I'll get around to this in the next few days.

@happenslol happenslol changed the title Percent After Pull String not working Allow all replacement strings in both current pull and overall count text Nov 7, 2024
@happenslol happenslol added enhancement New feature or request good first issue Good for newcomers labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants