Skip to content

Commit e2ab9fd

Browse files
Gil Finegregkh
Gil Fine
authored andcommitted
thunderbolt: Fix minimum allocated USB 3.x and PCIe bandwidth
commit f0b94c1 upstream. With the current bandwidth allocation we end up reserving too much for the USB 3.x and PCIe tunnels that leads to reduced capabilities for the second DisplayPort tunnel. Fix this by decreasing the USB 3.x allocation to 900 Mb/s which then allows both tunnels to get the maximum HBR2 bandwidth. This way, the reserved bandwidth for USB 3.x and PCIe, would be 1350 Mb/s (taking weights of USB 3.x and PCIe into account). So bandwidth allocations on a link are: USB 3.x + PCIe tunnels => 1350 Mb/s DisplayPort tunnel #1 => 17280 Mb/s DisplayPort tunnel #2 => 17280 Mb/s Total consumed bandwidth is 35910 Mb/s. So that all the above can be tunneled on a Gen 3 link (which allows maximum of 36000 Mb/s). Fixes: 582e70b ("thunderbolt: Change bandwidth reservations to comply USB4 v2") Signed-off-by: Gil Fine <gil.fine@linux.intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3dc5525 commit e2ab9fd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/thunderbolt/usb4.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -2380,13 +2380,13 @@ int usb4_usb3_port_release_bandwidth(struct tb_port *port, int *upstream_bw,
23802380
goto err_request;
23812381

23822382
/*
2383-
* Always keep 1000 Mb/s to make sure xHCI has at least some
2383+
* Always keep 900 Mb/s to make sure xHCI has at least some
23842384
* bandwidth available for isochronous traffic.
23852385
*/
2386-
if (consumed_up < 1000)
2387-
consumed_up = 1000;
2388-
if (consumed_down < 1000)
2389-
consumed_down = 1000;
2386+
if (consumed_up < 900)
2387+
consumed_up = 900;
2388+
if (consumed_down < 900)
2389+
consumed_down = 900;
23902390

23912391
ret = usb4_usb3_port_write_allocated_bandwidth(port, consumed_up,
23922392
consumed_down);

0 commit comments

Comments
 (0)