Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for complete coverage #73

Open
ulysseherbach opened this issue Sep 19, 2024 · 0 comments
Open

Add tests for complete coverage #73

ulysseherbach opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
CI/tests

Comments

@ulysseherbach
Copy link
Member

Add tests to reach complete coverage for:

  • harissa.inference.cardamom.base
  • harissa.inference.hartree.base

The solution should be to add a particular dataset in order to pass through:

  • if not res.success (cardamom line 242)
  • "parameter not improved" (hartree lines 172, 183, 189)
@ulysseherbach ulysseherbach added the enhancement New feature or request label Sep 19, 2024
@ulysseherbach ulysseherbach added this to the CI/tests milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
CI/tests
Development

No branches or pull requests
1 participant
@ulysseherbach