Skip to content

Commit

Permalink
fix(core): ignore HTTPS errors by default
Browse files Browse the repository at this point in the history
Fixes #86
  • Loading branch information
harlan-zw committed May 12, 2023
1 parent 56da447 commit a83d248
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/core/src/resolveConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export const resolveUserConfig: (userConfig: UserConfig) => Promise<ResolvedUser
width: config.lighthouseOptions?.screenEmulation?.width || 0,
height: config.lighthouseOptions?.screenEmulation?.height || 0,
},
ignoreHTTPSErrors: true,
}, config.puppeteerOptions || {})
}
else {
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { LH } from 'lighthouse'
import type { LaunchOptions, Page } from 'puppeteer-core'
import type { Hookable, NestedHooks } from 'hookable'
import type { App } from 'h3'
import type { PuppeteerNodeLaunchOptions } from 'puppeteer'
import type { Cluster, TaskFunction } from '../cluster'
import type { WS } from './router'

Expand Down Expand Up @@ -420,7 +421,7 @@ export interface ResolvedUserConfig {
/**
* Change the behaviour of puppeteer.
*/
puppeteerOptions: LaunchOptions
puppeteerOptions: PuppeteerNodeLaunchOptions
/**
* Change the behaviour of puppeteer-cluster.
*/
Expand Down

0 comments on commit a83d248

Please sign in to comment.