Remove /refs/tags or /refs/heads from Gogs remote File() when using build.Ref #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
You need to call |
|
Right, forgot about that... Done. |
appleboy
reviewed
Dec 22, 2016
| @@ -177,6 +178,12 @@ func (c *client) File(u *model.User, r *model.Repo, b *model.Build, f string) ([ | |||
| buildRef := b.Commit | |||
| if buildRef == "" { | |||
| buildRef = b.Ref | |||
|
|
|||
| // Remove refs/tags or refs/heads, Gogs needs a short ref | |||
| refPath := strings.SplitAfterN(b.Ref, "/", 3) | |||
There was a problem hiding this comment.
How about the following code for high performance?
refPath := strings.TrimPrefix(
strings.TrimPrefix(
b.Ref,
"refs/heads/",
),
"refs/tags/",
)https://github.com/drone/drone/blob/master/remote/bitbucketserver/convert.go#L105-L111
|
@appleboy I agree; that implementation is better. I adopted it. |
2 tasks
|
I have tested this with gitea v 1.0 and works very nice. |
|
Missing Features on http://readme.drone.io/0.5/install/setup/gogs/ should probably be updated. |
|
@jhasse New document is here: http://readme.drone.io/admin/setup-gogs/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drone incorrectly used the full Git ref to retrieve a file using the Gogs API.
This is now fixed by removing the path from the ref (when a ref is used to retrieve a file). Behavior when using a Sha is not changed.
This PR fixes issue #1870.