-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for WebM compatibility #27
Comments
@rigelk I think it needs one more tweak which I temporarily patched out over in MediaWiki land here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/TimedMediaHandler/+/master/patches/videojs-ogvjs-webm.patch That changes the |
Ah thanks! I get the error that |
Ah woops the patch was against the transpiled output. :) Needs to be
slightly tweaked, eg remove the 2 that gets added in the scoping
adjustments.
|
Ah I wasn't sure if it was due to the scoping, thanks! Seems to do the trick ; it's now in the PR: https://github.com/hartman/videojs-ogvjs/pull/28/files#diff-a4f485aa834ca5b3c24819fceb39c56fR556 |
ogv.js 1.5 includes WebM support enabled by default; should update the source checks so WebM audio and video sources get through.
The text was updated successfully, but these errors were encountered: