-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: in conditionals, don't render anything after an else branch #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7946818540Details
💛 - Coveralls |
harttle
requested changes
Feb 16, 2024
joel-hamilton
force-pushed
the
issue-670
branch
from
February 18, 2024 02:07
e2b22d0
to
c347c86
Compare
joel-hamilton
changed the title
fix: only render the first 'else' template in the case of multiples
fix: in conditionals, don't render anything after an else branch
Feb 18, 2024
joel-hamilton
force-pushed
the
issue-670
branch
from
February 18, 2024 02:21
c347c86
to
827f596
Compare
joel-hamilton
force-pushed
the
issue-670
branch
from
February 18, 2024 02:25
827f596
to
72c0175
Compare
harttle
reviewed
Feb 18, 2024
harttle
reviewed
Feb 18, 2024
harttle
reviewed
Feb 18, 2024
@all-contributors please add @joel-hamilton for code |
I've put up a pull request to add @joel-hamilton! 🎉 |
🎉 This PR is included in version 10.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces a simple rule: don't render anything after an
else
branch.There are several bugs currently where
if
,unless
andcase
conditionals can have branches that occur after anelse
render, or that branches after anelse
can actually cause theelse
branch itself not to render.Fixes: #670 and #672
Example
master
Behaviour:PR Behaviour: