Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow Commas in Parse Parameters Tokenizer #722

Closed
zachleat opened this issue Jul 21, 2024 · 0 comments
Closed

Option to allow Commas in Parse Parameters Tokenizer #722

zachleat opened this issue Jul 21, 2024 · 0 comments

Comments

@zachleat
Copy link
Contributor

While upgrading to use Liquid’s parameter parser in Eleventy (and away from our home-grown one that is old): 11ty/eleventy#2679 one of the biggest backwards compatibility issues that I think we’ll have is that our custom parser allowed the use of commas to separate parameters and the Liquid one does not (nor does it fail with an error—looks like it hangs).

https://liquidjs.com/tutorials/parse-parameters.html#Parse-Parameters-as-Values

I’m curious if this can be improved—and best case scenario would be to add support for optional commas! Or maybe an opt-in option? Thanks!

Repository owner locked and limited conversation to collaborators Jul 21, 2024
@harttle harttle converted this issue into discussion #724 Jul 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants