Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel validator and migrations #60

Closed
wants to merge 1 commit into from
Closed

Parallel validator and migrations #60

wants to merge 1 commit into from

Conversation

lopho
Copy link

@lopho lopho commented Dec 5, 2022 •
edited
Loading

  • Use threads to parallalize validation and migration.
  • Small cosmetic changes to warning messages in validation.
  • Skip unneeded operations in migrations
    • don't resize if size is correct
    • don't convert to RGB if it already is
    • copy file instead of saving with pillow if it's unchanged
  • Keep image format of input images (webp->webp, png->png ...)
    • old impl converted to jpeg at 75 quality -> artifacts
    • now quality 95 for jpeg and 100 for lossless webp (e.g. compression level)
  • fixes [FEATURE REQUEST] Add multi-threading/processing to the Dataset Validator #52

@lopho
parallel validator and migrations
bd60b13 
skip unneeded operations in migrations
keep image format in migrations
helpful warning messages in validator
This was referenced Dec 5, 2022
Closed
Open
@lopho lopho closed this Dec 13, 2022
@lopho lopho deleted the parallel branch December 13, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add multi-threading/processing to the Dataset Validator
1 participant
@lopho