Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify AudioHandle and AudioSink #18

Closed
harudagondi opened this issue Aug 24, 2022 · 0 comments · Fixed by #21
Closed

Unify AudioHandle and AudioSink #18

harudagondi opened this issue Aug 24, 2022 · 0 comments · Fixed by #21
Assignees
Labels
usability quality-of-life changes
Milestone

Comments

@harudagondi
Copy link
Owner

oddio::Stop implements oddio::Filter, thus Controlled signals can be accessed using only AudioSink by calling Filter::inner(&sink).control().

The solution is to remove AudioHandle entirely, and rely only on AudioSink for accessing inner controls.

@harudagondi harudagondi added the enhancement New feature or request label Aug 24, 2022
@harudagondi harudagondi added this to the 0.2 milestone Aug 24, 2022
@harudagondi harudagondi added usability quality-of-life changes and removed enhancement New feature or request labels Aug 26, 2022
@harudagondi harudagondi self-assigned this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability quality-of-life changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant