Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Chapter 4 (DNN Architectures) #586

Closed
zishenwan opened this issue Jan 4, 2025 · 1 comment · Fixed by #588
Closed

Feedback on Chapter 4 (DNN Architectures) #586

zishenwan opened this issue Jan 4, 2025 · 1 comment · Fixed by #588
Assignees
Labels
improvement Improve existing content

Comments

@zishenwan
Copy link
Collaborator

Some brief comments on Chapter 4 (DNN Architectures):

  • Visual plots: I feel adding more visual plots would be helpful, e.g., add a RNN structure plot in Sec.4.4.2; add a attention structure plot in Sec.4.5.2; add a Transformer structure plot in Sec.4.6.4. Some visualization tool links might also helpful (e.g., CNN visualization, Transformer visualization). Those visualization can give more intuitions alongside existing texts and equations

  • Sec.4.7:

    • Introduce roofline model concept might be helpful here, as it integrates compute/memory/data movement factors to offer insights on system-level design
    • Table.4.4: there's a cell missing in table (key challenges of sequential access), maybe can fill "access latency" (delays due to memory hierarchy or insufficient prefetching mechanisms)
@profvjreddi profvjreddi self-assigned this Jan 5, 2025
@profvjreddi profvjreddi added the improvement Improve existing content label Jan 5, 2025
@profvjreddi
Copy link
Contributor

Thanks @zishenwan for the constructive feedback 🙏

Those visualization elements you linked in are great. I wasn't aware of them! Please do let me know if there are others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve existing content
Projects
None yet
2 participants