Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3133: Use placeholder attribute for placeholder text. #3134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #3133: Use placeholder attribute for placeholder text. #3134

wants to merge 1 commit into from

Conversation

jenlampton
Copy link

@jenlampton jenlampton commented Aug 15, 2022 •
edited
Loading

Fixes #3133

Summary

  • Switched placeholder text from value attribute to placeholder attribute on input element.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • N/A If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

If your pull request is in reference to one or more open GitHub issues, please mention them here to keep the conversations linked together:

@jenlampton
Copy link
Author

jenlampton commented Aug 15, 2022 •
edited
Loading

The command npm install failed with the error The package-lock.json file was created with an old version of npm and a handful of deprecations, so I was not able to use Grunt to build the JavaScript files.

To test locally, I modified the chosen.jquery.js file directly since the change was very simple.

If someone else can get grunt working with the latest version of chosen, I could use some help with the build process for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use placeholder attribute on input elements for placeholder text (instead of value attribute)
1 participant
@jenlampton