Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: single line map page #121

Merged
merged 2 commits into from
Oct 15, 2023
Merged

fix: single line map page #121

merged 2 commits into from
Oct 15, 2023

Conversation

NoamGaash
Copy link
Member

Description

Please describe the suggested changes

screenshots

<-- paste here -->

@NoamGaash NoamGaash mentioned this pull request Oct 11, 2023
Closed
giladfuchs
giladfuchs approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@giladfuchs giladfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's working.
and now you can see line.
it's still many requests and needs some improvement in the future.
maybe on the backend side to get only the specific data!

giladfuchs

This comment was marked as duplicate.

Sign in to view

giladfuchs
giladfuchs approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@giladfuchs giladfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's working.
and now you can see line.
it's still many requests and needs some improvement in the future.
maybe on the backend side to get only the specific data!

@NoamGaash NoamGaash enabled auto-merge (squash) October 15, 2023 08:20
@NoamGaash NoamGaash mentioned this pull request Oct 15, 2023
Closed
@NoamGaash NoamGaash disabled auto-merge October 15, 2023 08:44
@NoamGaash NoamGaash merged commit 6868ee8 into main Oct 15, 2023
5 checks passed
@NoamGaash NoamGaash deleted the fix/single-line-map-page branch October 15, 2023 08:44
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladfuchs giladfuchs giladfuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoamGaash @giladfuchs