Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): close menu after navigation #414

Merged
merged 15 commits into from
Feb 7, 2024
Merged

fix(mobile): close menu after navigation #414

merged 15 commits into from
Feb 7, 2024

Conversation

Mordechai1323
Copy link
Collaborator

@Mordechai1323 Mordechai1323 commented Jan 20, 2024 •
edited by NoamGaash
Loading

Close the menu when a user clicks on an item in it, by setting setDrawerOpen to false when clicked.

close #413

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/7814416458/open-bus/bfcb2761fa67a1061f994f56544deb82c4d2b739/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/7814416458/open-bus/bfcb2761fa67a1061f994f56544deb82c4d2b739/storybook/index.html

@NoamGaash NoamGaash changed the title Closing the menu when a user clicks on it fix(mobile): close menu after click Jan 20, 2024
NoamGaash
NoamGaash approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
suggestion - maybe we should add some comment about the drawer thing being mobile only

shootermv
shootermv approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@shootermv
Copy link
Contributor

@Mordechai1323 do you need a help with solve the conflicts?

@Mordechai1323 Mordechai1323 enabled auto-merge (squash) January 24, 2024 18:38
@NoamGaash NoamGaash disabled auto-merge January 24, 2024 21:08
@NoamGaash NoamGaash changed the title fix(mobile): close menu after click fix(mobile): close menu after navigation Jan 24, 2024
@NoamGaash
Copy link
Member

Hi, how are you? do you need any help or have any question?

@Mordechai1323
Copy link
Collaborator Author

thanks❤️

@NoamGaash
Copy link
Member

run npm i, and push the updated package-lock

@Mordechai1323
Copy link
Collaborator Author

I did it.

@NoamGaash
Copy link
Member

have you seen the build output?
image

@shootermv shootermv merged commit e99683f into main Feb 7, 2024
18 checks passed
@shootermv shootermv deleted the featuer/Closing-menu-when-user-click branch February 7, 2024 13:01
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

@shootermv shootermv shootermv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing the menu when a user clicks on it
3 participants
@Mordechai1323 @shootermv @NoamGaash