Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(line-profile): add a map #557

Merged
merged 2 commits into from
Mar 7, 2024
Merged

feat(line-profile): add a map #557

merged 2 commits into from
Mar 7, 2024

Conversation

Tamir198
Copy link
Collaborator

@Tamir198 Tamir198 commented Mar 6, 2024

Added a map to the bottom of this page:

image

Fix #542

@Tamir198 Tamir198 requested a review from NoamGaash as a code owner March 6, 2024 16:26
NoamGaash
NoamGaash approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good starting point! Thanks 🏅
The next step would be inserting the date and time pickers

@Tamir198
Copy link
Collaborator Author

Tamir198 commented Mar 6, 2024 •
edited
Loading

So do you want me to do it in a new pr?
@NoamGaash

@NoamGaash
Copy link
Member

@Tamir198 it's up to you :)

@NoamGaash NoamGaash changed the title feat: Add map to line profile feat(line-profile): add a map Mar 7, 2024
@Tamir198
Copy link
Collaborator Author

Tamir198 commented Mar 7, 2024

I think I will want you to merge this and do it in a new pr just to prevent bug conflicts with Darkmift user who is also working on this part on the page.

Sounds good?

@Darkmift Darkmift mentioned this pull request Mar 7, 2024
Closed
@NoamGaash
Copy link
Member

NoamGaash commented Mar 7, 2024 •
edited
Loading

@Tamir198 sure, thanks. Let's merge it.
I gave you permissions to the repo, so feel free to merge things whenever you want (as long as there are no regressions and you've got at least one code-review)

@NoamGaash NoamGaash merged commit 8a928f5 into hasadna:main Mar 7, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
Merged
@NoamGaash
Copy link
Member

@all-contributors please add @Tamir198 for his code 👏 🏅

@allcontributors allcontributors bot mentioned this pull request Apr 22, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @Tamir198! 🎉

@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a map to the line profile page
2 participants
@Tamir198 @NoamGaash