new agencies should appear in the dashboard

[NoamGaash]

we should call https://open-bus-stride-api.hasadna.org.il/gtfs_agencies/list?date_from=2024-06-01 with dynamic date argument to make sure new agencies appear

[EyalIlan]

hey can i take this issue? please :)

[NoamGaash]

sure

[EyalIlan]

yay thanks :) I will start working on it

[NoamGaash]

another task (for separate pr) - add "דרך אגד" to the list of important operators

[asidelnik]

@NoamGaash
What does dynamic date mean?

Should date_from equal each date's current date?
Ex: today: 2024-06-11, tomorrow: 2024-06-12

Or should it equal each month's first date? (as in api url in this issue's description)
Ex: today: 2024-06-01, next month: 2024-07-01

The updated function in file agencyList.ts
Need to understand which variable to pass to the date_from: todayDate or firstDateInMonth?

export default async function getAgencyList(): Promise<Agency[]> {
  if (!agencyList) {
    const now = moment()
    const todayDate = now.clone().format('YYYY-MM-DD')
    const firstDateInMonth = now.clone().startOf('month').format('YYYY-MM-DD')
    const response = await fetch(`${BASE_PATH}/gtfs_agencies/list?date_from=${firstDateInMonth}`)

    const data = (await response.json()) as Awaited<Agency[]>
    agencyList = data.filter(Boolean) // filter empty entries
  }
  return agencyList
}

[NoamGaash]

I think providing yesterday's date would be the safest approach, but it's up to you to decide.

[asidelnik]

@NoamGaash Can you give me push & pull request permissions?
If you are wondering how I got here, it's through Dorit & yesterday's Hasadna meeting.
I was listening in the Zoom meeting.

[NoamGaash]

@asidelnik Welcome! It's great to see you here 👏

[NoamGaash]

is it related?

[YaelChen]

@NoamGaash I thought I could test this to see that the date is dynamic, but where is this being called?
I only see yesterday's date in the END DATE of trip existence and patterns.

[NoamGaash]

@YaelChen

open-bus-map-search/src/api/agencyList.ts

Lines 16 to 24 in 20b1e80

	export default async function getAgencyList(): Promise<Agency[]> {
	if (!agencyList) {
	const yesterday = moment().subtract(1, 'day').format('YYYY-MM-DD')
	const response = await fetch(`${BASE_PATH}/gtfs_agencies/list?date_from=${yesterday}`)
	const data = (await response.json()) as Awaited<Agency[]>
	agencyList = data.filter(Boolean) // filter empty entries
	}
	return agencyList
	}

I think that we can test few things here -

1. there's a call to a path that includes gtfs_agencies/list
2. the request contains a date_from with a recent date (let's say 0-3 days ago?)

And then we can mock the route response with some fake data - for example:

[{"date":"2020-02-02","operator_ref":1234,"agency_name":"להקת אווזי הבר"}]

to see that the new agency is reflected in the UI