Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn i18n.dir function calls in Donate_Modal into global CSS #977

Open
yontank opened this issue Dec 15, 2024 · 1 comment
Open

feat: turn i18n.dir function calls in Donate_Modal into global CSS #977

yontank opened this issue Dec 15, 2024 · 1 comment
Assignees

Comments

@yontank
Copy link
Collaborator

yontank commented Dec 15, 2024

As written in #973

Instead of calling the function every time the Modal opens, is it possible to call it with Global CSS Rules?

@yontank yontank self-assigned this Dec 15, 2024
@TomRytt
Copy link
Collaborator

TomRytt commented Dec 27, 2024

@yontank It was already global in theme.direction, However, that global did not update when toggling the language button, I added the logic to update it when goggling the language so it will be consistent and have one source of truth. Is it ok if I assign this to myself?

@NoamGaash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants