eth_getTransactionReceipt go-ethereum compatibility

[rafaelkallis]

Problem

We are facing a similar situation as in #149 , but for eth_getTransactionReceipt. Specifically there is a schema disagreement over log.transactionHash between the ethereum execution apis and go-ethereum.

The ethereum execution apis do not mark that property as required https://github.com/ethereum/execution-apis/blob/main/src/schemas/receipt.json#L18.

The go-ethereum client however does mark that property as required https://github.com/ethereum/go-ethereum/blob/master/core/types/log.go#L45.

Would be great if we can include the transactionHash inside logs so that we satisfy the go-ethereum validation.

Solution

The logs are mapped here on the relay node:

hedera-json-rpc-relay/packages/relay/src/lib/eth.ts

Lines 701 to 716 in 84fffed

	const answer = {
	blockHash: receiptResponse.block_hash.substring(0, 66),
	blockNumber: EthImpl.numberTo0x(receiptResponse.block_number),
	from: receiptResponse.from,
	to: receiptResponse.to,
	cumulativeGasUsed: EthImpl.numberTo0x(receiptResponse.block_gas_used),
	gasUsed: EthImpl.numberTo0x(receiptResponse.gas_used),
	contractAddress: createdContract,
	logs: receiptResponse.logs,
	logsBloom: receiptResponse.bloom,
	transactionHash: receiptResponse.hash,
	transactionIndex: EthImpl.numberTo0x(receiptResponse.transaction_index),
	effectiveGasPrice: EthImpl.numberTo0x(Number.parseInt(effectiveGas) * 10_000_000_000),
	root: receiptResponse.root,
	status: receiptResponse.status,
	};

const logs = receiptResponse.logs.map(log => ({ ...log, transactionHash: receiptResponse.hash}));

Alternatives

No response

[shemnon]

Can you post this finding to https://github.com/ethereum/execution-apis/issues? This part in particular

Specifically there is a schema disagreement over log.transactionHash between the ethereum execution apis and go-ethereum.

The ethereum execution apis do not mark that property as required https://github.com/ethereum/execution-apis/blob/main/src/schemas/receipt.json#L18.

The go-ethereum client however does mark that property as required https://github.com/ethereum/go-ethereum/blob/master/core/types/log.go#L45.

The core devs either need to make it required or geth needs to come into compliance. Either outcome is acceptable to me. But we should add it on our end.

[rafaelkallis]

reference ethereum/execution-apis#240 (merged!)