Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions API Should Return All Relevant Transactions #9606

Open
2 tasks
jnels124 opened this issue Oct 18, 2024 · 0 comments
Open
2 tasks

Transactions API Should Return All Relevant Transactions #9606

jnels124 opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement Type: New feature good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers rest Area: REST API

Comments

@jnels124
Copy link
Contributor

jnels124 commented Oct 18, 2024

Problem

parent_consensus_timestamp is only set on following children. #4672 made changes to exclude synthetic transactions and inadvertently excludes transactions that precede another transaction. For instance, a CRYPTOTRANSFER that creates a CRYPTOCREATEACCOUNT transaction. These CRYPTOCREATEACCOUNT transactions will have a non-zero nonce and will not have a parent_consensus_timestamp so the query adjustment in the mentioned pr will exclude these transactions in the response.

Solution

  • Determine other transaction types that may be effected
  • Adjust query so that all relevant transactions are returned

Alternatives

No response

@jnels124 jnels124 added enhancement Type: New feature rest Area: REST API labels Oct 18, 2024
@steven-sheehy steven-sheehy added good first issue Good for newcomers good first issue candidate Issues that can become a good first issue but need more description/context. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers rest Area: REST API
Projects
Status: 🏃‍♀ Sprint backlog
Development

No branches or pull requests

2 participants