Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enhanced Logger to accept a log file location #2298

Merged
merged 9 commits into from
Jun 3, 2024
Merged

fix: enhanced Logger to accept a log file location #2298

merged 9 commits into from
Jun 3, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented May 23, 2024 •
edited
Loading

Description:

  • enhanced Logger to accept a log file location
  • fixed some jsdoc mispellings
  • added src/grpc/GrpcServiceError.js toString() method, updated message, and add caused by stack trace
  • increased timeouts on some tests to prevent random failures in the pipeline when under a load
  • increased Logger test coverage
  • added sinon library for spy capabilities
  • added cgroup configuration and calls to build workflow to fix issue where GitHub runner loses communication with GitHub

Related issue(s):

Fixes #2297

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jeromy-cannon
added log to file capability
f0983b8 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this May 23, 2024
@jeromy-cannon jeromy-cannon changed the title added log to file capability fix: enhanced Logger to accept a log file location May 23, 2024
@jeromy-cannon jeromy-cannon marked this pull request as ready for review May 23, 2024 20:22
@jeromy-cannon jeromy-cannon requested review from a team as code owners May 23, 2024 20:22
@jeromy-cannon
updated test case and the way the grpc error is created
ba96866 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
include the original grpc error message in the new error
cdd33ba 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
bumped timeout because of pipeline failure
1ff63d1 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
agadzhalov
agadzhalov requested changes May 28, 2024
View reviewed changes
jeromy-cannon and others added 2 commits May 29, 2024 06:50
@jeromy-cannon @agadzhalov
Update src/grpc/GrpcServiceError.js
cda486d 
Co-authored-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
updates based on PR review feedback
33fa072 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon requested a review from agadzhalov May 29, 2024 17:59
@jeromy-cannon
don't error if the tmp dir log file does not exist
9ac414a 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
use cgroups to prevent github runner from losing communication with s…
eea9ed8 
…erver

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon requested review from a team as code owners May 29, 2024 20:37
@jeromy-cannon
fix syntax error
1223cd6 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon mentioned this pull request May 29, 2024
Closed
5 tasks
rbarker-dev
rbarker-dev approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@rbarker-dev rbarker-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agadzhalov
agadzhalov approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jeromy-cannon

@jeromy-cannon jeromy-cannon merged commit aa5411c into main Jun 3, 2024
9 checks passed
@jeromy-cannon jeromy-cannon deleted the 02297-log-to-file branch June 3, 2024 12:14
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Jun 28, 2024
Open
@swirlds-automation swirlds-automation mentioned this pull request Jul 3, 2024
Merged
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Jul 6, 2024
Closed
@si618 si618 mentioned this pull request Jul 6, 2024
Closed
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Jul 9, 2024
Closed
@swirlds-automation swirlds-automation mentioned this pull request Aug 22, 2024
Open
This was referenced Aug 31, 2024
Closed
Closed
Closed
This was referenced Sep 4, 2024
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@rbarker-dev rbarker-dev rbarker-dev approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

@ochikov ochikov Awaiting requested review from ochikov

@petreze petreze Awaiting requested review from petreze

@svetoslav-nikol0v svetoslav-nikol0v Awaiting requested review from svetoslav-nikol0v

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera was automatically assigned from hashgraph/release-engineering

Assignees

@jeromy-cannon jeromy-cannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable logger constructor to accept a log file destination
4 participants
@jeromy-cannon @agadzhalov @svetoslav-nikol0v @rbarker-dev