Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Mnemonic.toEcdsaPrivateKey() function for "legacy" ECDSA private keys #390

Open
krsticmilos96 opened this issue Sep 26, 2024 · 0 comments
Open

Missing Mnemonic.toEcdsaPrivateKey() function for "legacy" ECDSA private keys #390

krsticmilos96 opened this issue Sep 26, 2024 · 0 comments
Labels
enhancement New feature or request P1
Milestone
v0.34.0

Comments

@krsticmilos96
Copy link

Problem

If private key is created from mnemonic using Mnemonic.toEcdsaPrivateKey() we cannot use Mnemonic.toStandardECDSAsecp256k1PrivateKey() to retrieve that private key from memonics. Those two functions are having different algorithm and they are returning different values. Because of that we need to support both toEcdsaPrivateKey() and toStandardECDSAsecp256k1PrivateKey().

Solution

Implement toEcdsaPrivateKey() and toStandardECDSAsecp256k1PrivateKey()

Alternatives

No response
@krsticmilos96 krsticmilos96 added the enhancement New feature or request label Sep 26, 2024
@SimiHunjan SimiHunjan added this to the v0.33.0 milestone Oct 1, 2024
@SimiHunjan SimiHunjan added the P1 label Oct 1, 2024
@rwalworth rwalworth modified the milestones: v0.33.0, v0.34.0 Oct 29, 2024
@rwalworth rwalworth modified the milestones: v0.34.0, v0.35.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P1
Projects
None yet
Milestone
v0.34.0
Development

No branches or pull requests
3 participants
@SimiHunjan @krsticmilos96 @rwalworth