Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account and alias create with non-zero shard and realm #17603

Merged
merged 13 commits into from
Feb 4, 2025

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Jan 29, 2025

Description:
Adding support for non-zero shard and realm in cryptoCreate flows covering alias as well.

Related issue(s):
#17485

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Sorry, something went wrong.

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov added this to the v0.60 milestone Jan 29, 2025
@ibankov ibankov self-assigned this Jan 29, 2025
@ibankov ibankov changed the title account and alias create with non-zero shard and realm feat: account and alias create with non-zero shard and realm Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.00%. Comparing base (2bd8919) to head (832bedc).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../impl/handlers/CryptoGetAccountBalanceHandler.java 33.33% 0 Missing and 4 partials ⚠️
.../hedera/node/app/throttle/ThrottleAccumulator.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17603   +/-   ##
=========================================
  Coverage     68.99%   69.00%           
- Complexity    22917    22923    +6     
=========================================
  Files          2639     2639           
  Lines         98950    98961   +11     
  Branches      10261    10262    +1     
=========================================
+ Hits          68275    68290   +15     
+ Misses        26785    26783    -2     
+ Partials       3890     3888    -2     
Files with missing lines Coverage Δ
...va/com/hedera/node/app/hapi/utils/CommonUtils.java 87.17% <100.00%> (+0.69%) ⬆️
...p/service/token/impl/ReadableAccountStoreImpl.java 94.87% <100.00%> (+0.27%) ⬆️
...rvice/token/impl/handlers/CryptoCreateHandler.java 77.71% <100.00%> (+1.85%) ⬆️
.../com/hedera/node/app/service/token/AliasUtils.java 64.15% <100.00%> (+2.92%) ⬆️
...ode/app/service/token/api/AccountSummariesApi.java 85.71% <100.00%> (+0.25%) ⬆️
.../hedera/node/app/throttle/ThrottleAccumulator.java 77.72% <0.00%> (ø)
.../impl/handlers/CryptoGetAccountBalanceHandler.java 91.13% <33.33%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2bd8919) 98733 72014 72.94%
Head commit (832bedc) 98744 (+11) 72027 (+13) 72.94% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17603) 22 22 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
wip
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
fixing
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
fix
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov marked this pull request as ready for review January 30, 2025 14:14
@ibankov ibankov requested review from a team as code owners January 30, 2025 14:14
fix
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Comment. Otherwise LGTM! Thanks @ibankov

Copy link
Contributor

@vtronkov vtronkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibankov ibankov merged commit 510a026 into main Feb 4, 2025
46 checks passed
@ibankov ibankov deleted the alias-check-based-on-realm branch February 4, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-zero shard and realm for account alias
3 participants