Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected event "Transfer" to be emitted, but isnt #898

Closed
mgarbs opened this issue Aug 8, 2024 · 3 comments
Closed

Expected event "Transfer" to be emitted, but isnt #898

mgarbs opened this issue Aug 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mgarbs
Copy link

mgarbs commented Aug 8, 2024

Description

It appears some events are not emitted for the following tests within Axelargateway:

should allow the operators to burn external tokens
should allow the operators to burn external tokens even if the deposit address has ether
should allow the operators to burn the external token multiple times from the same address
All fail with: AssertionError: Expected event "Transfer" to be emitted, but it wasn't

Sample Transaction Hashes for Tests:
should allow the operators to burn the external token multiple times from the same address: https://hashscan.io/testnet/transaction/1723125697.573982315
should allow the operators to burn external tokens: https://hashscan.io/testnet/transaction/1723125656.258025003

One of their partners faced similar issues, which was related to selfdestruct. Comment for reference: onflow/flow-evm-gateway#404 (comment)

Steps to reproduce

  1. Look at the tests
  2. See sample transaction
  3. Observe Transfer event not emitted

Additional context

No response

Hedera network

testnet

Version

v0.52

Operating system

None

@mgarbs mgarbs added the bug Something isn't working label Aug 8, 2024
@ebadiere ebadiere self-assigned this Aug 8, 2024
@ebadiere ebadiere assigned acuarica and ebadiere and unassigned ebadiere Aug 8, 2024
@acuarica acuarica moved this from Backlog to Epics In Progress in Smart Contract Sprint Board Aug 8, 2024
@acuarica acuarica moved this from Epics In Progress to Sprint Backlog in Smart Contract Sprint Board Aug 8, 2024
@acuarica
Copy link
Contributor

Hi @mgarbs, thanks for sending this. We managed to reproduce the error locally, and verify the error didn't happen on an Ethereum network, e.g., Sepolia. At the moment, the issue seems to boil down to contracts after selfdestruct still have bytecode attached.

We continue investigating the root cause of the issue.

@acuarica
Copy link
Contributor

After further investigation, we managed to find the root cause. The issue is how selfdestruct handles deletion within the same transaction. More details can be found in tracking issue hashgraph/hedera-services#14835. We expect to have a fix for this soon.

@mgarbs
Copy link
Author

mgarbs commented Oct 15, 2024

This worked guys! Thanks @acuarica

@mgarbs mgarbs closed this as completed Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Smart Contract Sprint Board Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants