Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update per Q3 audit findings #312

Merged
merged 3 commits into from
Oct 29, 2024
Merged

ci: Update per Q3 audit findings #312

merged 3 commits into from
Oct 29, 2024

Conversation

mishomihov00
Copy link
Contributor

Description:

Update per Q3 audit findings.

Related issue(s):

Related to #267

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00
ci: Update per Q3 audit findings
3054f86 
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@mishomihov00 mishomihov00 requested a review from a team October 29, 2024 08:42
@mishomihov00 mishomihov00 self-assigned this Oct 29, 2024
@mishomihov00 mishomihov00 linked an issue Oct 29, 2024 that may be closed by this pull request
ci: [2024-Q3] CI/CD Audit Story #267
Open
53 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

JUnit Test Report

   66 files  ±0     66 suites  ±0   2m 41s ⏱️ ±0s
1 244 tests ±0  1 241 ✅ ±0   3 💤 ±0  0 ❌ ±0 
7 099 runs  ±0  7 080 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 7556452. ± Comparison against base commit 845c93d.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both. 
, 1
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 

com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1

♻️ This comment has been updated with latest results.

@mishomihov00
ci: Fix harden runner step version
8bf766f 
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@mishomihov00
ci: Update setup gradle action
7556452 
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@github-actions GitHub Actions
Copy link

Integration Test Report

    296 files  +  7      296 suites  +7   8m 50s ⏱️ +8s
104 153 tests +424  104 153 ✅ +424  0 💤 ±0  0 ❌ ±0 
104 381 runs  +424  104 381 ✅ +424  0 💤 ±0  0 ❌ ±0 

Results for commit 7556452. ± Comparison against base commit 845c93d.

This pull request removes 3 and adds 427 tests. Note that renamed tests count towards both. 
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007ff65c4e1990@43bd69e0
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007ff65c4e1bc8@234ee7b9
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007ff65c4e2000@16a08d5d

com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1435] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1436] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1437] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1438] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1439] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1440] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.QueryHeaderTest ‑ [1441] NoToStringWrapper{com.hedera.hapi.node.base.QueryHeader}
com.hedera.hapi.node.base.tests.TransactionFeeScheduleTest ‑ [83] NoToStringWrapper{com.hedera.hapi.node.base.TransactionFeeSchedule}
com.hedera.hapi.node.base.tests.TransactionFeeScheduleTest ‑ [84] NoToStringWrapper{com.hedera.hapi.node.base.TransactionFeeSchedule}
com.hedera.hapi.node.base.tests.TransactionTest ‑ [1435] NoToStringWrapper{com.hedera.hapi.node.base.Transaction}
…

san-est
san-est approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@san-est san-est left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishomihov00 mishomihov00 merged commit c8a5145 into main Oct 29, 2024
10 checks passed
@mishomihov00 mishomihov00 deleted the 267-ci-2024-q3-cicd-audit-story branch October 29, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@san-est san-est san-est approved these changes

Assignees

@mishomihov00 mishomihov00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: [2024-Q3] CI/CD Audit Story
2 participants
@mishomihov00 @san-est