Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON serialization unit tests generated for enum with reserved ordinals fail #339

Open
tinker-michaelj opened this issue Jan 4, 2025 · 0 comments
Open

JSON serialization unit tests generated for enum with reserved ordinals fail #339

tinker-michaelj opened this issue Jan 4, 2025 · 0 comments

Comments

@tinker-michaelj
Copy link
Contributor

tinker-michaelj commented Jan 4, 2025 •
edited
Loading

Description

When I marked some previously used enum ordinal values as reserved for type HederaFunctionality, the unit tests generated for JSON codecs of types using HederaFunctionality failed when comparing with the protoc-generated JSON.

In particular, the PBJ JSON codec uses the string "reserved" for the enum value while the expected output of protoc JSON uses the reserved integral value (see screenshot).

Screenshot 2025-01-04 at 12 54 15 PM

Steps to reproduce

As above.

Additional context

No response

Hedera network

No response

Version

v0.9.2

Operating system

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tinker-michaelj