Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node add call triggers no prompt found for local-build-path erro… #517

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • fix: node add call triggers no prompt found for local-build-path error and exits

Related Issues

…r and exits (#515)

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this Aug 27, 2024
@jeromy-cannon jeromy-cannon marked this pull request as ready for review August 27, 2024 17:51
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners August 27, 2024 17:51
Copy link
Contributor

Unit Test Results - Linux

  1 files   19 suites   46s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit 2905d9d.

Copy link
Contributor

Unit Test Results - Windows

  1 files   19 suites   1m 33s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Node PEM Stop Tests Coverage Report

12 tests   12 ✅  2m 37s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Relay Tests Coverage Report

1 files  1 suites   2m 43s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Node PFX Kill Tests Coverage Report

12 tests   12 ✅  2m 52s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Tests Coverage Report

57 tests   57 ✅  4m 22s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Node Add Tests Coverage Report

10 tests   10 ✅  6m 37s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 2905d9d.

Copy link
Contributor

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 39s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 2905d9d.

Copy link
Contributor

github-actions bot commented Aug 27, 2024

E2E Node Local Build Tests Coverage Report

8 tests   8 ✅  2m 42s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 2905d9d.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d5acbe31 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d5acbe3) Report Missing Report Missing Report Missing
Head commit (2905d9d) 3720 3042 81.77%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#517) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (eab3340) to head (2905d9d).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   81.40%   81.52%   +0.12%     
==========================================
  Files          35       35              
  Lines        4414     4449      +35     
  Branches      755      675      -80     
==========================================
+ Hits         3593     3627      +34     
- Misses        819      822       +3     
+ Partials        2        0       -2     
Files Coverage Δ
src/commands/flags.mjs 95.52% <100.00%> (+0.36%) ⬆️
src/commands/node.mjs 78.75% <ø> (-0.92%) ⬇️
src/commands/prompts.mjs 69.48% <100.00%> (+0.60%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit e97c37f into main Aug 27, 2024
41 checks passed
@jeromy-cannon jeromy-cannon deleted the 00515-cherry-pick branch August 27, 2024 19:38
swirlds-automation added a commit that referenced this pull request Aug 27, 2024
## [0.28.1](v0.28.0...v0.28.1) (2024-08-27)

### Bug Fixes

* node add call triggers no prompt found for local-build-path erro… ([#517](#517)) ([e97c37f](e97c37f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants