-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node add call triggers no prompt found for local-build-path erro… #517
Conversation
…r and exits (#515) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Unit Test Results - Linux 1 files 19 suites 46s ⏱️ Results for commit 2905d9d. |
Unit Test Results - Windows 1 files 19 suites 1m 33s ⏱️ Results for commit 2905d9d. |
E2E Node PEM Stop Tests Coverage Report12 tests 12 ✅ 2m 37s ⏱️ Results for commit 2905d9d. |
E2E Relay Tests Coverage Report1 files 1 suites 2m 43s ⏱️ Results for commit 2905d9d. |
E2E Node PFX Kill Tests Coverage Report12 tests 12 ✅ 2m 52s ⏱️ Results for commit 2905d9d. |
E2E Tests Coverage Report57 tests 57 ✅ 4m 22s ⏱️ Results for commit 2905d9d. |
E2E Node Add Tests Coverage Report10 tests 10 ✅ 6m 37s ⏱️ Results for commit 2905d9d. |
E2E Mirror Node Tests Coverage Report 1 files 1 suites 3m 39s ⏱️ Results for commit 2905d9d. |
E2E Node Local Build Tests Coverage Report8 tests 8 ✅ 2m 42s ⏱️ Results for commit 2905d9d. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 81.40% 81.52% +0.12%
==========================================
Files 35 35
Lines 4414 4449 +35
Branches 755 675 -80
==========================================
+ Hits 3593 3627 +34
- Misses 819 822 +3
+ Partials 2 0 -2
|
## [0.28.1](v0.28.0...v0.28.1) (2024-08-27) ### Bug Fixes * node add call triggers no prompt found for local-build-path erro… ([#517](#517)) ([e97c37f](e97c37f))
🎉 This PR is included in version 0.28.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues