Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flags to be context specific to the subcommand that is using them #524

Closed
jeromy-cannon opened this issue Aug 30, 2024 · 1 comment
Assignees
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete.

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Aug 30, 2024

make it so that flags are subcommand specific, example --private-key is boolean for solo account get whereas, string for solo account create.

Note:
I think this should already be do-able without any changes needing to be made. All we have to do is create a second flag and make name of the variable different, we can still re-use the same alias and same CLI name, but have different descriptions and different meanings. As long as the two overlapping flags are not used within the same subcommand.

@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Aug 30, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Aug 30, 2024
@jeromy-cannon jeromy-cannon added P3 Low priority issue. Will not impact the release schedule if not complete. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Improvement Code changes driven by non business requirements and removed Improvement Code changes driven by non business requirements labels Aug 30, 2024
@jeromy-cannon jeromy-cannon moved this from 🔖 Ready to 🏗 In progress in Solo Oct 21, 2024
@jeromy-cannon
Copy link
Contributor Author

closing:

I think this should already be do-able without any changes needing to be made. All we have to do is create a second flag and make name of the variable different, we can still re-use the same alias and same CLI name, but have different descriptions and different meanings. As long as the two overlapping flags are not used within the same subcommand.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Solo Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants