feat: add node add-prepare and node add-execute commands #533

Ivo-Yankov · 2024-09-03T12:19:47Z

Description

Separates the flow of solo node add into 3 new commands that can be executed separately and one after the other: solo node add-prepare, solo node add-submit-transactions, solo node add-execute.
Removes the --node-id property and automatically sets it to the next number.
Adds an optional --admin-key property. If not present the genesis key will be used.

The behaviour of the new commands is as follows:

solo node add-prepare --gossip-keys true --tls-keys true --release-tag v0.53.2 --namespace solo-e2e --output-dir context [--admin-key xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
---------
Initialize
Check that PVCs are enabled
Identify existing network nodes
    Check network pod: node1
    Determine new node account number
Generate Gossip key
    Backup old files
    Gossip key for node: node2
Generate gRPC TLS key
    Backup old files
    TLS key for node: node2
Load signing key certificate
Compute mTLS certificate hash
Prepare gossip endpoints
Prepare grpc service endpoints
Prepare upgrade zip file for node upgrade process
Check existing nodes staked amount
Save context data

Saves data from the ctx object to the specified directory by --output-dir

solo node add-submit-transactions --namespace solo-e2e --input-dir context
---------
Initialize
Load context data
Send node create transaction
Send prepare upgrade transaction
Send freeze upgrade transaction

Loads data into the ctx object from the specified directory by --input-dir

solo node add-execute --namespace solo-e2e --input-dir context [--local-build-path xxxxxxx]
---------
Initialize
Load context data
Identify existing network nodes
Download generated files from an existing node
Prepare staging directory
Copy node keys to secrets
Check network nodes are frozen
Get node logs and configs
Deploy new network node
Kill nodes to pick up updated configMaps
Check node pods are running
Fetch platform software into all network nodes
Download last state from an existing node
Upload last saved state to new network node
Setup new network node
Start network nodes
Check all nodes are ACTIVE
Check all node proxies are ACTIVE
Stake new node
Trigger stake weight calculate
Finalize

Loads data into the ctx object from the specified directory by --input-dir

Related Issues

Closes Reusable components of subcommands to be leveraged for SDK testing #522

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

github-actions · 2024-09-03T12:25:04Z

E2E Relay Tests Coverage Report

1 files ±0 1 suites ±0 2m 42s ⏱️ +11s
6 tests ±0 6 ✅ ±0 0 💤 ±0 0 ❌ ±0
7 runs ±0 7 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T12:26:02Z

E2E Mirror Node Tests Coverage Report

1 files ±0 1 suites ±0 3m 31s ⏱️ -5s
13 tests ±0 13 ✅ ±0 0 💤 ±0 0 ❌ ±0
14 runs ±0 14 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

…be-leveraged-for-sdk-testing # Conflicts: # src/commands/node.mjs

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

github-actions · 2024-09-05T13:50:58Z

Unit Test Results - Linux

1 files ±0 19 suites ±0 26s ⏱️ -1s
122 tests ±0 122 ✅ ±0 0 💤 ±0 0 ❌ ±0
148 runs ±0 148 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:52:16Z

Unit Test Results - Windows

1 files ±0 19 suites ±0 53s ⏱️ +4s
122 tests ±0 122 ✅ ±0 0 💤 ±0 0 ❌ ±0
148 runs ±0 148 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:53:45Z

E2E Node PEM Stop Tests Coverage Report

13 tests ±0 13 ✅ ±0 2m 37s ⏱️ +6s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:54:16Z

E2E Node PFX Kill Tests Coverage Report

13 tests 13 ✅ 3m 4s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit bde7ca3.

github-actions · 2024-09-05T13:54:55Z

E2E Tests Coverage Report

58 tests ±0 58 ✅ ±0 3m 49s ⏱️ +10s
9 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 7367c4c. ± Comparison against base commit 32dcf0c.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:54:57Z

E2E Node Local Build Tests Coverage Report

10 tests ±0 10 ✅ ±0 2m 18s ⏱️ +4s
2 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:56:08Z

E2E Node Update Tests Coverage Report

12 tests ±0 12 ✅ ±0 4m 47s ⏱️ +6s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T13:56:47Z

E2E Node Delete Tests Coverage Report

10 tests ±0 10 ✅ ±0 5m 51s ⏱️ -10s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-05T14:05:36Z

E2E Node Add Tests Coverage Report

22 tests ±0 22 ✅ ±0 11m 35s ⏱️ -6s
2 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

…be-leveraged-for-sdk-testing # Conflicts: # src/commands/node.mjs

github-actions · 2024-09-10T11:12:30Z

E2E Node PEM Kill Tests Coverage Report

13 tests ±0 13 ✅ ±0 2m 45s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

src/commands/node.mjs

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

…be-leveraged-for-sdk-testing # Conflicts: # README.md # src/commands/flags.mjs # src/commands/node.mjs

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

…be-leveraged-for-sdk-testing

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

…be-leveraged-for-sdk-testing # Conflicts: # src/core/k8.mjs

github-actions · 2024-09-12T21:05:17Z

E2E Standard Tests Coverage Report

1 files ±0 9 suites ±0 4m 6s ⏱️ +2s
58 tests ±0 58 ✅ ±0 0 💤 ±0 0 ❌ ±0
59 runs ±0 59 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 33424dd. ± Comparison against base commit e6c79eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

github-actions · 2024-09-13T09:19:45Z

E2E Node Add - Separate commands Tests Coverage Report

11 tests 11 ✅ 5m 43s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 33424dd.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

package.json

test/e2e/commands/separate_node_add_local.test.mjs

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

test/test_add.mjs

test/test_add_separate.mjs

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))

swirlds-automation · 2024-09-17T19:29:11Z

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add add-prepare and add-execute commands

e682fbd

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov changed the title ~~Аdd add-prepare and add-execute commands~~ Аdd node add-prepare and node add-execute commands Sep 3, 2024

Ivo-Yankov self-assigned this Sep 3, 2024

Ivo-Yankov added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Sep 3, 2024

Ivo-Yankov added 3 commits September 5, 2024 16:22

feat: add add-execute-transactions

9d9c22f

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Merge branch 'main' into 00522-reusable-components-of-subcommands-to-…

963dc2a

…be-leveraged-for-sdk-testing # Conflicts: # src/commands/node.mjs

chore: run linter

bde7ca3

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov added 2 commits September 9, 2024 18:00

feat: update flags

999ce6f

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

feat: optional adminKey flag

1058752

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov changed the title ~~Аdd node add-prepare and node add-execute commands~~ feat: add node add-prepare and node add-execute commands Sep 10, 2024

Merge branch 'main' into 00522-reusable-components-of-subcommands-to-…

e054fb0

…be-leveraged-for-sdk-testing # Conflicts: # src/commands/node.mjs

test: add e2e test

569187e

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

jeromy-cannon reviewed Sep 10, 2024

View reviewed changes

src/commands/node.mjs Outdated Show resolved Hide resolved

Ivo-Yankov added 4 commits September 11, 2024 11:43

test: revert e2e change

fa18389

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Merge branch 'main' into 00522-reusable-components-of-subcommands-to-…

48cd4c2

…be-leveraged-for-sdk-testing # Conflicts: # README.md # src/commands/flags.mjs # src/commands/node.mjs

test: revert e2e change

a0b74f5

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

debug e2e

75d5768

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov added 3 commits September 12, 2024 23:45

Merge branch 'main' into 00522-reusable-components-of-subcommands-to-…

e598e05

…be-leveraged-for-sdk-testing

fix: re-add z to copyFrom

7367c4c

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Merge branch 'main' into 00522-reusable-components-of-subcommands-to-…

67502cd

…be-leveraged-for-sdk-testing # Conflicts: # src/core/k8.mjs

test: add separate e2e CI

bf48d4c

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov added 4 commits September 13, 2024 12:48

chore: rename e2e files to avoid collision

4b52d99

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

chore: fix ci

e149d2c

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

chore: standard e2e command

07e6b6e

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

fix: pass local path to execute command

0bbdfb1

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

jeromy-cannon reviewed Sep 13, 2024

View reviewed changes

package.json Show resolved Hide resolved

jeromy-cannon reviewed Sep 13, 2024

View reviewed changes

test/e2e/commands/separate_node_add_local.test.mjs Outdated Show resolved Hide resolved

Ivo-Yankov added 2 commits September 13, 2024 16:55

chore: update config.yaml with standard ignore settings

52f1be8

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

remove unnecessary test

80c09b9

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

jeromy-cannon reviewed Sep 13, 2024

View reviewed changes

test/test_add.mjs Show resolved Hide resolved

jeromy-cannon reviewed Sep 13, 2024

View reviewed changes

test/test_add_separate.mjs Outdated Show resolved Hide resolved

Ivo-Yankov and others added 5 commits September 13, 2024 17:00

remove unnecessary test

a06f8c6

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

nit: alphabetical sorting

0fc9a77

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

nit: revert sorting

c478f49

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

lint and sort items

20dbf9e

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

no need to do hedera build on test not using hedera

c88060c

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon previously approved these changes Sep 13, 2024

View reviewed changes

reverted sort, adminKey was an extra and not a flag

33424dd

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon dismissed their stale review via 33424dd September 13, 2024 16:01

jeromy-cannon approved these changes Sep 13, 2024

View reviewed changes

jeromy-cannon merged commit a184775 into main Sep 13, 2024
39 of 42 checks passed

jeromy-cannon deleted the 00522-reusable-components-of-subcommands-to-be-leveraged-for-sdk-testing branch September 13, 2024 16:26

swirlds-automation added the released label Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add node add-prepare and node add-execute commands #533

feat: add node add-prepare and node add-execute commands #533

Ivo-Yankov commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

swirlds-automation commented Sep 17, 2024

feat: add node add-prepare and node add-execute commands #533

feat: add node add-prepare and node add-execute commands #533

Conversation

Ivo-Yankov commented Sep 3, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Relay Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Mirror Node Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 5, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Sep 5, 2024

E2E Node PFX Kill Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Node Local Build Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Node Update Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Node Delete Tests Coverage Report

github-actions bot commented Sep 5, 2024 • edited Loading

E2E Node Add Tests Coverage Report

github-actions bot commented Sep 10, 2024 • edited Loading

E2E Node PEM Kill Tests Coverage Report

github-actions bot commented Sep 12, 2024 • edited Loading

E2E Standard Tests Coverage Report

github-actions bot commented Sep 13, 2024 • edited Loading

E2E Node Add - Separate commands Tests Coverage Report

swirlds-automation commented Sep 17, 2024

Ivo-Yankov commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading