fix: jsdoc errors due to unrecognized format #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 81.66% 83.17% +1.51%
==========================================
Files 35 36 +1
Lines 4429 4815 +386
Branches 671 742 +71
==========================================
+ Hits 3617 4005 +388
+ Misses 812 810 -2
... and 5 files with indirect coverage changes |
JeffreyDallas
changed the title
jeromy-cannon
approved these changes
Sep 10, 2024
swirlds-automation
added a commit
that referenced
this pull request
Sep 17, 2024
## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some jsdoc errors because it did not support some auto generated mjs documentation styles.
Also run jsdoc when doing syntax format check so we do not need separate jsdoc check from ci flow as mentioned in #544
Related Issues