Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code to reuse some repeated node command steps #558

Closed
JeffreyDallas opened this issue Sep 10, 2024 · 1 comment · Fixed by #562
Closed

Clean up code to reuse some repeated node command steps #558

JeffreyDallas opened this issue Sep 10, 2024 · 1 comment · Fixed by #562
Assignees
@JeffreyDallas
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team released

Comments

@JeffreyDallas
Copy link
Contributor

Feature to Enhance

Some node command steps such as check pod status, 
check node active status being used in many places.

Requested Enhancement

Better to consolidate its usage as reusable function calls

Business Need

Reduce code size and avoid copy & paste errors

Additional Context

No response
@JeffreyDallas JeffreyDallas added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team labels Sep 10, 2024
@JeffreyDallas JeffreyDallas self-assigned this Sep 10, 2024
@JeffreyDallas JeffreyDallas mentioned this issue Sep 11, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: separate repeated steps as individual functions hashgraph/solo
2 participants
@JeffreyDallas @swirlds-automation